Jincheng Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85737?usp=email )
Change subject: soc/intel/xeon_sp: Remove assert when creating DMAR component ......................................................................
soc/intel/xeon_sp: Remove assert when creating DMAR component
Not all domains have VT-d device, e.g. for IOAT, domains under the same IIO stack share one VT-d device. Remove the asserts to directly continue when no VT-d device found.
Change-Id: I64256baf10abb509d48267e58e6a9e264b916e72 Signed-off-by: Jincheng Li jincheng.li@intel.com --- M src/soc/intel/xeon_sp/uncore_acpi.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/85737/1
diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c index 8651944..2dbafe3 100644 --- a/src/soc/intel/xeon_sp/uncore_acpi.c +++ b/src/soc/intel/xeon_sp/uncore_acpi.c @@ -387,7 +387,6 @@ while ((domain = dev_find_path(domain, DEVICE_PATH_DOMAIN))) { dev = pcidev_path_behind(domain->downstream, PCI_DEVFN(VTD_DEV_NUM, VTD_FUNC_NUM)); - assert(dev); if (!dev) continue; /* Only add devices for the current socket */ @@ -445,7 +444,6 @@ while ((domain = dev_find_path(domain, DEVICE_PATH_DOMAIN))) { dev = pcidev_path_behind(domain->downstream, PCI_DEVFN(VTD_DEV_NUM, VTD_FUNC_NUM)); - assert(dev); if (!dev) continue; /* See if there is a resource with the appropriate index. */ @@ -539,7 +537,6 @@ while ((domain = dev_find_path(domain, DEVICE_PATH_DOMAIN))) { dev = pcidev_path_behind(domain->downstream, PCI_DEVFN(VTD_DEV_NUM, VTD_FUNC_NUM)); - assert(dev); if (!dev) continue; if (is_dev_on_domain0(dev)) {