[S] Change in coreboot[master]: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs - coreboot-gerrit

29 Nov 2022


      Attention is currently required from: Kane Chen, Tim Wawrzynczak, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64467 )
Change subject: cpu/x86/mtrr: Print apic id in when set up MTRRs for BSP/APs
......................................................................
Patch Set 3:
(1 comment)
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/64467/comment/d51a2d0e_2b0329d1 
PS3, Line 358: lapicid
why not calling into `cpu_index()` to know the CPU ID instead APIC ID, which would be difficult to know as the range is wide now (between 00 to 0x40)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/64467
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2e1e411f86fa3ea42ed50546facec31b89c3e1
Gerrit-Change-Number: 64467
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kane Chen kane.chen@intel.com
Gerrit-Attention: Kane Chen kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 29 Nov 2022 08:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment