[M] Change in coreboot[master]: mb/google/octopus/variants/phaser: Add memory ram id=3 to 8GB size
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69925 )
Change subject: mb/google/octopus/variants/phaser: Add memory ram id=3 to 8GB size ......................................................................
Patch Set 1:
(15 comments)
File src/mainboard/google/octopus/variants/phaser/memory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/4a45244d_ccd2209e PS1, Line 24: size_t rt; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/4e3d9995_0be6498e PS1, Line 24: size_t rt; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/e56b25d3_49f6d01d PS1, Line 25: gpio_t pads[] = { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/ba6eb632_b802a0c4 PS1, Line 25: gpio_t pads[] = { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/9adbc38f_ff0173ce PS1, Line 26: [3] = MEM_CONFIG3, [2] = MEM_CONFIG2, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/ffb013c0_79b87357 PS1, Line 26: [3] = MEM_CONFIG3, [2] = MEM_CONFIG2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/9d0729d9_2ee5ce6b PS1, Line 27: [1] = MEM_CONFIG1, [0] = MEM_CONFIG0, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/a9f05cce_852cd22b PS1, Line 27: [1] = MEM_CONFIG1, [0] = MEM_CONFIG0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/ceed1dbe_9e4bdb88 PS1, Line 28: }; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/4997532d_f3462e28 PS1, Line 28: }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/ce62d6a8_fe0d3c32 PS1, Line 30: rt = gpio_base2_value(pads, ARRAY_SIZE(pads)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/02323fbe_67d94227 PS1, Line 30: rt = gpio_base2_value(pads, ARRAY_SIZE(pads)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/e978d2d9_b3f13653 PS1, Line 31: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/c7ff05c5_05fbea1b PS1, Line 31: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1 please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164356): https://review.coreboot.org/c/coreboot/+/69925/comment/8cdf12a8_170c1324 PS1, Line 32: } adding a line without newline at end of file
-
build bot (Jenkins) (Code Review)