Attention is currently required from: Arthur Heymans, Varshit Pandya.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email )
Change subject: vendorcode/amd: Hook up opensil ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: I'll take a look at reworking this, since I'd like to have the opensil code in a submodule.
File src/vendorcode/amd/Kconfig:
https://review.coreboot.org/c/coreboot/+/76511/comment/8223eb93_a9210862 : PS4, Line 26: if SOC_AMD_OPENSIL I'd rather this if went inside the opensil Kconfig.
By putting it here, it looks like the opensil Kconfig file is only sourced if SOC_AMD_OPENSIL is enabled, but the source command always happens. This if does restrict what's inside that Kconfig from being enabled, but by putting the 'if' statement inside the opensil Kconfig, that's more obvious.