[S] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD CnviWifiCore

[Subrata Banik (Code Review)]

Attention is currently required from: Tarun Tuli, Kapil Porwal, Paul Menzel, Eric Lai.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74306 )

Change subject: soc/intel/meteorlake: Hook up UPD CnviWifiCore
......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/meteorlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/74306/comment/9ad76c58_ce00285f 
PS3, Line 565: s_cfg->CnviWifiCore = config->cnvi_wifi_core;
> > `CnviMode` is a master option so setting `CnviWifiCore` to 1/0 does not make any difference when `CnviMode` is 0.
> > Here assert() is helping to catch potential misconfiguration.
>
> that's true. how about a non-serial image where assert lib would replaced by NULL. then how can we catch such misconfiguration is my question?
>
> Also, answering @eric's question, yes, ideally we should club all relevant UPDs (wifi, bt core and bt offline)

also just thinking loud here, what is the benefit of asserting the boot when we know the user had messed up the configuration like cnvi is disabled bt wifi/bt core is enabled? shouldn't we just try to self-heal and boot the platform by knowing cnvi is disable meaning wifi/bt core can't be enabeld? may be worth adding a ERROR msg so that during parsing the AP fw log, one would catch this problem?