Attention is currently required from: Christian Walter, Julius Werner, Krystian Hebel, Sergii Dmytruk.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159 )
Change subject: security/tpm: make tis_probe() return tpm_family
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/b06cc68d_83dd5945
PS1, Line 461: *tpm_family = 1;
Judging by the differences in addresses they might have implemented their own protocol derived from […]
if (TPM_INTF_CAPABILITY.InterfaceVersion == 0)
tpm_family = 1 // (TIS <= 1.21, not used by TPM 2.0 devices)
else // (TIS 1.3, used both by TPM 1.2 and 2.0)
if (TPM_STS.tpmFamily == 0)
tpm_family = 1
else
tpm_family = 2
This procedure is wrong, I added an appropriate procedure in parent change as a comment.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69159
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5006e0cdfef76ff79ce9e1cf280fcd5515ae01b0
Gerrit-Change-Number: 69159
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Mon, 21 Nov 2022 15:17:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment