Change in coreboot[master]: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Cheng-Yi Chiang (Code Review)

14 Oct 2019 14 Oct '19

8:54 a.m.

Cheng-Yi Chiang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36030 )

Change subject: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios ......................................................................

mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios

Use RT1011 driver for Helios. Select CHROMEOS_DSM_CALIB to set device properties for RT1011 speaker calibration.

Signed-off-by: Cheng-Yi Chiang cychiang@chromium.org Change-Id: I1010be15466c5060aa1d73318393853a2515daac --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/36030/1

diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index fbc4c15..160194b 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -30,3 +30,5 @@ bool "-> Helios" select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_16384 + select CHROMEOS_DSM_CALIB + select DRIVERS_I2C_RT1011

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Cheng-Yi Chiang (Code Review)

14 Oct 14 Oct

9:31 a.m.

Hello Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36030

to look at the new patch set (#3).

Change subject: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios ......................................................................

mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios

Use RT1011 driver for Helios. Select CHROMEOS_DSM_CALIB to set device properties for RT1011 speaker calibration.

Signed-off-by: Cheng-Yi Chiang cychiang@chromium.org Change-Id: I1010be15466c5060aa1d73318393853a2515daac --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/36030/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/36030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1010be15466c5060aa1d73318393853a2515daac Gerrit-Change-Number: 36030 Gerrit-PatchSet: 3 Gerrit-Owner: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Paul Fagerburg (Code Review)

1:10 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36030 )

Change subject: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios ......................................................................

Patch Set 3: Code-Review+2

Shelley Chen (Code Review)

9:52 p.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36030 )

Change subject: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36030/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36030/3//COMMIT_MSG@11 PS3, Line 11: Please add BUG, BRANCH, and TEST fields.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1010be15466c5060aa1d73318393853a2515daac Gerrit-Change-Number: 36030 Gerrit-PatchSet: 3 Gerrit-Owner: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Oct 2019 04:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Cheng-Yi Chiang (Code Review)

11:50 p.m.

Hello Paul Fagerburg, Tim Wawrzynczak, Shelley Chen, Hung-Te Lin, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36030

to look at the new patch set (#4).

Change subject: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios ......................................................................

mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios

Use RT1011 driver for Helios. Select CHROMEOS_DSM_CALIB to set device properties for RT1011 speaker calibration.

BUG=b:140397934 BRANCH=none TEST=On Helios, with patch series, check realtek,r0_calib and realtek,temperature_calib are available to rt1011 codec driver.

Signed-off-by: Cheng-Yi Chiang cychiang@chromium.org Change-Id: I1010be15466c5060aa1d73318393853a2515daac --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/36030/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/36030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1010be15466c5060aa1d73318393853a2515daac Gerrit-Change-Number: 36030 Gerrit-PatchSet: 4 Gerrit-Owner: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Paul Fagerburg (Code Review)

15 Oct 15 Oct

7:58 a.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36030 )

Change subject: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/36030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1010be15466c5060aa1d73318393853a2515daac Gerrit-Change-Number: 36030 Gerrit-PatchSet: 5 Gerrit-Owner: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Oct 2019 14:58:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

22 Oct 22 Oct

6:57 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36030 )

Change subject: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1010be15466c5060aa1d73318393853a2515daac Gerrit-Change-Number: 36030 Gerrit-PatchSet: 7 Gerrit-Owner: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 23 Oct 2019 01:57:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:38 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36030 )

Change subject: mb/google/hatch: Select RT1011 and CHROMEOS_DSM_CALIB for Helios ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1010be15466c5060aa1d73318393853a2515daac Gerrit-Change-Number: 36030 Gerrit-PatchSet: 7 Gerrit-Owner: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Cheng-Yi Chiang cychiang@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 23 Oct 2019 02:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1852

days inactive

1861

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Cheng-Yi Chiang (Code Review)
Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Paul Fagerburg (Code Review)
Shelley Chen (Code Review)