Attention is currently required from: Shobhit Srivastava, Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Sridhar Siricilla, Kane Chen.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62861 )
Change subject: soc/intel/adl: Remove IOM Mctp command from TCSS ASL
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/62861/comment/e5995394_ff96656e
PS2, Line 725: /*
: * If the TCSS Deven in normal state, then Save current TCSS DEVEN value and
: * clear it.
: */
: Local0 = 0
: While (_SB.PCI0.TXHC.VDID != 0xFFFFFFFF) {
: If (DSGS () == 0) {
: DSCR (1)
: }
: Local0++
: If (Local0 == 5) {
: Printf("pCode mailbox command failed.")
: Break
: }
: }
Is this part still necessary too? I don't see the reference code doing this.
yes, they are not needed. Maulik, i think you can remove them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62861
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f066bcc4a8f475a15ddd12ef5ed87d7298312bb
Gerrit-Change-Number: 62861
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Shobhit Srivastava
shobhit.srivastava@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shobhit Srivastava
shobhit.srivastava@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Thu, 17 Mar 2022 01:41:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment