Attention is currently required from: Anjaneya "Reddy" Chagam, Felix Singer, Jonathan Zhang, Shuo Liu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78787?usp=email )
Change subject: doc/soc/intel/xeon_sp: Add Xeon Scalable processor coreboot community preview guide ......................................................................
Patch Set 5: Code-Review-1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78787/comment/3610b9f8_352ddb61 : PS5, Line 7: Xeon Scalable processor coreboot Xeon-SP
https://review.coreboot.org/c/coreboot/+/78787/comment/f5bae96e_7ca75539 : PS5, Line 10: Put a ':' here and the URL on the line below.
Patchset:
PS5: Thanks a lot for writing this up! It looks good to me, except for some line length issues.
File Documentation/soc/intel/xeon_sp/community_preview_guide.md:
https://review.coreboot.org/c/coreboot/+/78787/comment/e175832d_edf9e72a : PS5, Line 9: For Granite Rapids coreboot, we are going to perform a phased upstreaming strategy according to the maturity of the code. : A community preview branch is opensource at https://review.coreboot.org/plugins/gitiles/intel-dev-pub/. : : The community preview branch initially contains codes on legacy feature enabling and matured patch set for platform support. : More platform support code will come with the platform development. The subsequent upstreaming work will be based on : this branch. It provides 2 board targets, Please break these (and other) long lines to fit within 96 columns [1].
Typically we try to keep within the coding style parameters for documentation, although there is an exception for URLs or tables that would don't render properly if broken.
[1] https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/main/Docum...