Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Tim Wawrzynczak.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79219?usp=email )
Change subject: [UNTESTED] acpi/acpi: add & use ACPI_DBG2_PORT_SERIAL_16550_GENERIC
......................................................................
Patch Set 1:
(2 comments)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/79219/comment/9e6d4bd6_7c36be96 :
PS1, Line 869: ACPI_DBG2_PORT_SERIAL_16550
Maybe rename this one to `ACPI_DBG2_PORT_SERIAL_16550_IO_ONLY`
https://review.coreboot.org/c/coreboot/+/79219/comment/90c9b67e_93f13053 :
PS1, Line 875: ACPI_DBG2_PORT_SERIAL_16550_GENERIC
If you rename the 0x00 one, maybe we can just call this `ACPI_DBG2_PORT_SERIAL_16550`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79219?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I816bb22e6f76e661c8b8e39a2a4cb83b0085acb5
Gerrit-Change-Number: 79219
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 29 Nov 2023 16:18:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment