Attention is currently required from: Furquan Shaikh, Martin Roth, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51446 )
Change subject: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/alderlake/include/soc/me.h:
https://review.coreboot.org/c/coreboot/+/51446/comment/e5a2ae8e_61313f28
PS2, Line 65: } me_bios_payload_hob;
Why not move this struct to telemetry.c and drop the #include <fsp/util.h> and preprocessor guard?
File src/soc/intel/alderlake/telemetry.c:
https://review.coreboot.org/c/coreboot/+/51446/comment/f47c0c0a_18628a66
PS2, Line 45: hob = fsp_next_hob(hob)) {
I'd refactor this loop so that the goto is not necessary:
const struct hob_header *hob = fsp_get_hob_list();
for (; hob && hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b7728d3da0d38dc0f1b465743486025dcf354b3
Gerrit-Change-Number: 51446
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 12 Mar 2021 20:27:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment