Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35899 )
Change subject: soc/qualcomm: Remove default ops to generate bootblock.bin ......................................................................
soc/qualcomm: Remove default ops to generate bootblock.bin
This is done by default in the main Makefile.inc.
TEST: With BUILD_TIMELESS=1 the resulting binary is identical before and after the change.
Change-Id: Ie85e023df1f1c2b0f115e4f92719a511f60019c3 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/qualcomm/qcs405/Makefile.inc M src/soc/qualcomm/sdm845/Makefile.inc 2 files changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/35899/1
diff --git a/src/soc/qualcomm/qcs405/Makefile.inc b/src/soc/qualcomm/qcs405/Makefile.inc index 0ebfcae..f21ea54 100644 --- a/src/soc/qualcomm/qcs405/Makefile.inc +++ b/src/soc/qualcomm/qcs405/Makefile.inc @@ -52,8 +52,4 @@
CPPFLAGS_common += -Isrc/soc/qualcomm/qcs405/include
-$(objcbfs)/bootblock.bin: $(objcbfs)/bootblock.raw.bin - @printf "Generating: $(subst $(obj)/,,$(@))\n" - cp $(objcbfs)/bootblock.raw.bin $(objcbfs)/bootblock.bin - endif diff --git a/src/soc/qualcomm/sdm845/Makefile.inc b/src/soc/qualcomm/sdm845/Makefile.inc index c20be14..fd39bd9 100644 --- a/src/soc/qualcomm/sdm845/Makefile.inc +++ b/src/soc/qualcomm/sdm845/Makefile.inc @@ -48,8 +48,4 @@ CPPFLAGS_common += -Isrc/soc/qualcomm/sdm845/include CPPFLAGS_common += -Isrc/soc/qualcomm/common/include
-$(objcbfs)/bootblock.bin: $(objcbfs)/bootblock.raw.bin - @printf "Generating: $(subst $(obj)/,,$(@))\n" - cp $(objcbfs)/bootblock.raw.bin $(objcbfs)/bootblock.bin - endif
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35899 )
Change subject: soc/qualcomm: Remove default ops to generate bootblock.bin ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35899 )
Change subject: soc/qualcomm: Remove default ops to generate bootblock.bin ......................................................................
soc/qualcomm: Remove default ops to generate bootblock.bin
This is done by default in the main Makefile.inc.
TEST: With BUILD_TIMELESS=1 the resulting binary is identical before and after the change.
Change-Id: Ie85e023df1f1c2b0f115e4f92719a511f60019c3 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/35899 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/soc/qualcomm/qcs405/Makefile.inc M src/soc/qualcomm/sdm845/Makefile.inc 2 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/soc/qualcomm/qcs405/Makefile.inc b/src/soc/qualcomm/qcs405/Makefile.inc index 0ebfcae..f21ea54 100644 --- a/src/soc/qualcomm/qcs405/Makefile.inc +++ b/src/soc/qualcomm/qcs405/Makefile.inc @@ -52,8 +52,4 @@
CPPFLAGS_common += -Isrc/soc/qualcomm/qcs405/include
-$(objcbfs)/bootblock.bin: $(objcbfs)/bootblock.raw.bin - @printf "Generating: $(subst $(obj)/,,$(@))\n" - cp $(objcbfs)/bootblock.raw.bin $(objcbfs)/bootblock.bin - endif diff --git a/src/soc/qualcomm/sdm845/Makefile.inc b/src/soc/qualcomm/sdm845/Makefile.inc index c20be14..fd39bd9 100644 --- a/src/soc/qualcomm/sdm845/Makefile.inc +++ b/src/soc/qualcomm/sdm845/Makefile.inc @@ -48,8 +48,4 @@ CPPFLAGS_common += -Isrc/soc/qualcomm/sdm845/include CPPFLAGS_common += -Isrc/soc/qualcomm/common/include
-$(objcbfs)/bootblock.bin: $(objcbfs)/bootblock.raw.bin - @printf "Generating: $(subst $(obj)/,,$(@))\n" - cp $(objcbfs)/bootblock.raw.bin $(objcbfs)/bootblock.bin - endif
-
Arthur Heymans (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)