Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/19540 )
Change subject: soc/intel/common/block: Add Intel common CPU code ......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/Kcon... File src/soc/intel/common/block/cpu/Kconfig:
PS11, Line 3: help set 'default n' Also, Common CPU code is supported for SOCs starting from SKL, KBL, APL, GLK and future.. It would good to mention it here.
https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/cpu.... File src/soc/intel/common/block/cpu/cpu.c:
PS11, Line 58: { 0, 0 }, GLK CPUIDs?
https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/cpu_... File src/soc/intel/common/block/cpu/cpu_early.c:
PS11, Line 164: * 7:0 - MAX_TURBO_1_CORE : * 15:8 - MAX_TURBO_2_CORES : * 23:16 - MAX_TURBO_3_CORES : * 31:24 - MAX_TURBO_4_CORES please reformat text.
https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/include/... File src/soc/intel/common/block/include/intelblocks/cpu.h:
PS11, Line 36: GLK CPUIDs?
https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/include/... File src/soc/intel/common/block/include/intelblocks/msr.h:
PS11, Line 124: /* MTRR_CAP_MSR bits */ : #define SMRR_SUPPORTED (1<<11) : #define PRMRR_SUPPORTED (1<<12) add one more tab to align
-
Pratikkumar V Prajapati (Code Review)