Attention is currently required from: Arthur Heymans, Benjamin Doron, Felix Held, Martin L Roth, Patrick Rudolph.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83425?usp=email )
Change subject: drivers/smmstore: add logic to disable capsule update handling code
......................................................................
Patch Set 14:
(1 comment)
Patchset:
PS10:
Thanks for the explanation! So, if I'm understanding this right, coreboot only has to gather and coa […]
Correct. It takes at least 2 reboots (assuming ME is disabled and doesn't need to be re-enabled): warm reset to let the firmware perform an update and reset of any kind to boot with updated firmware.
Changing state of ME takes a hard reset, which can result in 4 resets in total. That seems to be in line with how proprietary firmware is being updated (boot followed by a reset to toggle ME state is quite fast and might not be very obvious for the end user that it even occurs).
By the way, you resolved the comment but left -1, was that intentional?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83425?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3dc175ea313aae1edae304520595b82db7206cbb
Gerrit-Change-Number: 83425
Gerrit-PatchSet: 14
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 14 Feb 2025 17:33:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com