Change in ...coreboot[master]: Docs/project_ideas: Expand "toolchain" project description
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31804
Change subject: Docs/project_ideas: Expand "toolchain" project description ......................................................................
Docs/project_ideas: Expand "toolchain" project description
One of packages do us little good, we need to be able to automate building them.
Change-Id: Idd9b6b231435ea9d6e946c7ccaa71174b497742c Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/contributing/project_ideas.md 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/31804/1
diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md index 9a2d414..e7dd3a7 100644 --- a/Documentation/contributing/project_ideas.md +++ b/Documentation/contributing/project_ideas.md @@ -29,6 +29,12 @@ Windows, Mac OS. For Windows, this should also include the environment (shell, make, ...).
+The scripts for to generate these packages should be usable on a Linux +host, as that's what we're using for our automated build testing system +that we could extend to provide current packages going forward. This +might include automating some virtualization system (eg. QEMU or CrosVM) for +non-Linux builds or docker for different Linux distributions. + ### Requirements * coreboot knowledge: Should know how to build coreboot images and where the compiler comes into play in our build system.
Patrick Georgi has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/31804 )
Change subject: Docs/project_ideas: Expand "toolchain" project description ......................................................................
Docs/project_ideas: Expand "toolchain" project description
One-off packages do us little good, we need to be able to automate building them.
Change-Id: Idd9b6b231435ea9d6e946c7ccaa71174b497742c Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/contributing/project_ideas.md 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/31804/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31804 )
Change subject: Docs/project_ideas: Expand "toolchain" project description ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... File Documentation/contributing/project_ideas.md:
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... PS2, Line 32: Linux GNU/Linux
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... PS2, Line 32: to generate generating
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... PS2, Line 36: docker Docker
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31804 )
Change subject: Docs/project_ideas: Expand "toolchain" project description ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... File Documentation/contributing/project_ideas.md:
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... PS2, Line 32: to generate
generating
I'd rather drop the "for"
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... PS2, Line 32: Linux
GNU/Linux
Why not on Linux systems not using GNU packages?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31804 )
Change subject: Docs/project_ideas: Expand "toolchain" project description ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... File Documentation/contributing/project_ideas.md:
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... PS2, Line 32: to generate
I'd rather drop the "for"
Done
https://review.coreboot.org/#/c/31804/2/Documentation/contributing/project_i... PS2, Line 36: docker
Docker
Done
Hello Angel Pons, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31804
to look at the new patch set (#3).
Change subject: Docs/project_ideas: Expand "toolchain" project description ......................................................................
Docs/project_ideas: Expand "toolchain" project description
One-off packages do us little good, we need to be able to automate building them.
Change-Id: Idd9b6b231435ea9d6e946c7ccaa71174b497742c Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/contributing/project_ideas.md 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/31804/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31804 )
Change subject: Docs/project_ideas: Expand "toolchain" project description ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31804 )
Change subject: Docs/project_ideas: Expand "toolchain" project description ......................................................................
Docs/project_ideas: Expand "toolchain" project description
One-off packages do us little good, we need to be able to automate building them.
Change-Id: Idd9b6b231435ea9d6e946c7ccaa71174b497742c Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31804 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/contributing/project_ideas.md 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md index da51246..d16e9fe 100644 --- a/Documentation/contributing/project_ideas.md +++ b/Documentation/contributing/project_ideas.md @@ -29,6 +29,12 @@ Windows, Mac OS. For Windows, this should also include the environment (shell, make, ...).
+The scripts to generate these packages should be usable on a Linux +host, as that's what we're using for our automated build testing system +that we could extend to provide current packages going forward. This +might include automating some virtualization system (eg. QEMU or CrosVM) for +non-Linux builds or Docker for different Linux distributions. + ### Requirements * coreboot knowledge: Should know how to build coreboot images and where the compiler comes into play in our build system.
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)