Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50655 )
Change subject: AGESA,binaryPI boards: Drop _SI scope with _SST in ASL ......................................................................
AGESA,binaryPI boards: Drop _SI scope with _SST in ASL
Change-Id: I0fca35753c93ba928a0f67bb68a6cfdc26c0e756 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- D src/mainboard/amd/olivehill/acpi/si.asl M src/mainboard/amd/olivehill/dsdt.asl D src/mainboard/amd/parmer/acpi/si.asl M src/mainboard/amd/parmer/dsdt.asl D src/mainboard/amd/thatcher/acpi/si.asl M src/mainboard/amd/thatcher/dsdt.asl D src/mainboard/asrock/imb-a180/acpi/si.asl M src/mainboard/asrock/imb-a180/dsdt.asl D src/mainboard/asus/am1i-a/acpi/si.asl M src/mainboard/asus/am1i-a/dsdt.asl D src/mainboard/asus/f2a85-m/acpi/si.asl M src/mainboard/asus/f2a85-m/dsdt.asl D src/mainboard/bap/ode_e20XX/acpi/si.asl M src/mainboard/bap/ode_e20XX/dsdt.asl D src/mainboard/biostar/a68n_5200/acpi/si.asl M src/mainboard/biostar/a68n_5200/dsdt.asl D src/mainboard/biostar/am1ml/acpi/si.asl M src/mainboard/biostar/am1ml/dsdt.asl D src/mainboard/gizmosphere/gizmo2/acpi/si.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl D src/mainboard/hp/abm/acpi/si.asl M src/mainboard/hp/abm/dsdt.asl D src/mainboard/hp/pavilion_m6_1035dx/acpi/si.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl D src/mainboard/lenovo/g505s/acpi/si.asl M src/mainboard/lenovo/g505s/dsdt.asl D src/mainboard/msi/ms7721/acpi/si.asl M src/mainboard/msi/ms7721/dsdt.asl D src/mainboard/pcengines/apu2/acpi/si.asl M src/mainboard/pcengines/apu2/dsdt.asl 30 files changed, 0 insertions(+), 195 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/50655/1
diff --git a/src/mainboard/amd/olivehill/acpi/si.asl b/src/mainboard/amd/olivehill/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/amd/olivehill/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/amd/olivehill/dsdt.asl b/src/mainboard/amd/olivehill/dsdt.asl index b739bb1..c86cf27 100644 --- a/src/mainboard/amd/olivehill/dsdt.asl +++ b/src/mainboard/amd/olivehill/dsdt.asl @@ -67,8 +67,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" } /* End of ASL file */ diff --git a/src/mainboard/amd/parmer/acpi/si.asl b/src/mainboard/amd/parmer/acpi/si.asl deleted file mode 100644 index 3e1317a..0000000 --- a/src/mainboard/amd/parmer/acpi/si.asl +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } - } /* End Scope SI */ diff --git a/src/mainboard/amd/parmer/dsdt.asl b/src/mainboard/amd/parmer/dsdt.asl index 86e0a82..b3ebbf5 100644 --- a/src/mainboard/amd/parmer/dsdt.asl +++ b/src/mainboard/amd/parmer/dsdt.asl @@ -60,9 +60,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" - } /* End of ASL file */ diff --git a/src/mainboard/amd/thatcher/acpi/si.asl b/src/mainboard/amd/thatcher/acpi/si.asl deleted file mode 100644 index 3e1317a..0000000 --- a/src/mainboard/amd/thatcher/acpi/si.asl +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } - } /* End Scope SI */ diff --git a/src/mainboard/amd/thatcher/dsdt.asl b/src/mainboard/amd/thatcher/dsdt.asl index 86e0a82..b3ebbf5 100644 --- a/src/mainboard/amd/thatcher/dsdt.asl +++ b/src/mainboard/amd/thatcher/dsdt.asl @@ -60,9 +60,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" - } /* End of ASL file */ diff --git a/src/mainboard/asrock/imb-a180/acpi/si.asl b/src/mainboard/asrock/imb-a180/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/asrock/imb-a180/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/asrock/imb-a180/dsdt.asl b/src/mainboard/asrock/imb-a180/dsdt.asl index b739bb1..c86cf27 100644 --- a/src/mainboard/asrock/imb-a180/dsdt.asl +++ b/src/mainboard/asrock/imb-a180/dsdt.asl @@ -67,8 +67,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" } /* End of ASL file */ diff --git a/src/mainboard/asus/am1i-a/acpi/si.asl b/src/mainboard/asus/am1i-a/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/asus/am1i-a/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/asus/am1i-a/dsdt.asl b/src/mainboard/asus/am1i-a/dsdt.asl index 8da27ed..a1efc5d 100644 --- a/src/mainboard/asus/am1i-a/dsdt.asl +++ b/src/mainboard/asus/am1i-a/dsdt.asl @@ -58,8 +58,5 @@
/* Describe SMBUS for the Southbridge */ #include <southbridge/amd/agesa/hudson/acpi/smbus.asl> - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" } /* End of ASL file */ diff --git a/src/mainboard/asus/f2a85-m/acpi/si.asl b/src/mainboard/asus/f2a85-m/acpi/si.asl deleted file mode 100644 index 3e1317a..0000000 --- a/src/mainboard/asus/f2a85-m/acpi/si.asl +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } - } /* End Scope SI */ diff --git a/src/mainboard/asus/f2a85-m/dsdt.asl b/src/mainboard/asus/f2a85-m/dsdt.asl index 6682e7b..c3f4ba3 100644 --- a/src/mainboard/asus/f2a85-m/dsdt.asl +++ b/src/mainboard/asus/f2a85-m/dsdt.asl @@ -78,9 +78,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" - } /* End of ASL file */ diff --git a/src/mainboard/bap/ode_e20XX/acpi/si.asl b/src/mainboard/bap/ode_e20XX/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/bap/ode_e20XX/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/bap/ode_e20XX/dsdt.asl b/src/mainboard/bap/ode_e20XX/dsdt.asl index b739bb1..c86cf27 100644 --- a/src/mainboard/bap/ode_e20XX/dsdt.asl +++ b/src/mainboard/bap/ode_e20XX/dsdt.asl @@ -67,8 +67,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" } /* End of ASL file */ diff --git a/src/mainboard/biostar/a68n_5200/acpi/si.asl b/src/mainboard/biostar/a68n_5200/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/biostar/a68n_5200/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/biostar/a68n_5200/dsdt.asl b/src/mainboard/biostar/a68n_5200/dsdt.asl index b739bb1..c86cf27 100644 --- a/src/mainboard/biostar/a68n_5200/dsdt.asl +++ b/src/mainboard/biostar/a68n_5200/dsdt.asl @@ -67,8 +67,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" } /* End of ASL file */ diff --git a/src/mainboard/biostar/am1ml/acpi/si.asl b/src/mainboard/biostar/am1ml/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/biostar/am1ml/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/biostar/am1ml/dsdt.asl b/src/mainboard/biostar/am1ml/dsdt.asl index f9243a3..0b57286 100644 --- a/src/mainboard/biostar/am1ml/dsdt.asl +++ b/src/mainboard/biostar/am1ml/dsdt.asl @@ -74,8 +74,5 @@ /* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl"
- /* Define the System Indicators for the platform */ - #include "acpi/si.asl" - } /* End of ASL file */ diff --git a/src/mainboard/gizmosphere/gizmo2/acpi/si.asl b/src/mainboard/gizmosphere/gizmo2/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/gizmosphere/gizmo2/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/gizmosphere/gizmo2/dsdt.asl b/src/mainboard/gizmosphere/gizmo2/dsdt.asl index b739bb1..c86cf27 100644 --- a/src/mainboard/gizmosphere/gizmo2/dsdt.asl +++ b/src/mainboard/gizmosphere/gizmo2/dsdt.asl @@ -67,8 +67,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" } /* End of ASL file */ diff --git a/src/mainboard/hp/abm/acpi/si.asl b/src/mainboard/hp/abm/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/hp/abm/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/hp/abm/dsdt.asl b/src/mainboard/hp/abm/dsdt.asl index b739bb1..c86cf27 100644 --- a/src/mainboard/hp/abm/dsdt.asl +++ b/src/mainboard/hp/abm/dsdt.asl @@ -67,8 +67,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" } /* End of ASL file */ diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/si.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/si.asl deleted file mode 100644 index 3e1317a..0000000 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/si.asl +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } - } /* End Scope SI */ diff --git a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl index 785b772..689c3e6 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl @@ -66,9 +66,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" - } /* End of ASL file */ diff --git a/src/mainboard/lenovo/g505s/acpi/si.asl b/src/mainboard/lenovo/g505s/acpi/si.asl deleted file mode 100644 index 3e1317a..0000000 --- a/src/mainboard/lenovo/g505s/acpi/si.asl +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } - } /* End Scope SI */ diff --git a/src/mainboard/lenovo/g505s/dsdt.asl b/src/mainboard/lenovo/g505s/dsdt.asl index 50c5933..c7ab792 100644 --- a/src/mainboard/lenovo/g505s/dsdt.asl +++ b/src/mainboard/lenovo/g505s/dsdt.asl @@ -66,9 +66,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" - } /* End of ASL file */ diff --git a/src/mainboard/msi/ms7721/acpi/si.asl b/src/mainboard/msi/ms7721/acpi/si.asl deleted file mode 100644 index 3e1317a..0000000 --- a/src/mainboard/msi/ms7721/acpi/si.asl +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } - } /* End Scope SI */ diff --git a/src/mainboard/msi/ms7721/dsdt.asl b/src/mainboard/msi/ms7721/dsdt.asl index 3dbcf46..3e67f63 100644 --- a/src/mainboard/msi/ms7721/dsdt.asl +++ b/src/mainboard/msi/ms7721/dsdt.asl @@ -57,9 +57,5 @@
/* Define the Thermal zones and methods for the platform */ #include "acpi/thermal.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" - } /* End of ASL file */ diff --git a/src/mainboard/pcengines/apu2/acpi/si.asl b/src/mainboard/pcengines/apu2/acpi/si.asl deleted file mode 100644 index 25c1dca..0000000 --- a/src/mainboard/pcengines/apu2/acpi/si.asl +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Scope(_SI) { - Method(_SST, 1) { - /* DBGO("\_SI\_SST\n") */ - /* DBGO(" New Indicator state: ") */ - /* DBGO(Arg0) */ - /* DBGO("\n") */ - } -} /* End Scope SI */ diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl index e05f55b..61edb10 100644 --- a/src/mainboard/pcengines/apu2/dsdt.asl +++ b/src/mainboard/pcengines/apu2/dsdt.asl @@ -57,8 +57,5 @@
/* Define the General Purpose Events for the platform */ #include "acpi/gpe.asl" - - /* Define the System Indicators for the platform */ - #include "acpi/si.asl" } /* End of ASL file */
-
Kyösti Mälkki (Code Review)