Attention is currently required from: Furquan Shaikh, Martin Roth, Henry Sun, Evan Green, Justin TerAvest, Karthik Ramasubramanian.
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49469 )
Change subject: mb/google/dedede/var/drawcia: Add support to handle pen detection
......................................................................
Patch Set 16:
(4 comments)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/49469/comment/b1e1be6d_cc6f364e
PS15, Line 10: bid
Nit: Name it as pre_board6_gpio_table
Done
https://review.coreboot.org/c/coreboot/+/49469/comment/10801b2c_4c09d0d9
PS15, Line 17: bid_6
Nit: Name it as board6_gpio_table
Done
https://review.coreboot.org/c/coreboot/+/49469/comment/814ed646_42e6e1e3
PS15, Line 19: /* C12 : AP_PEN_DET_ODL */
Add a comment that the "PEN_DET_ODL has an external pull-up and hence no pad termination. […]
Done
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/49469/comment/26a4492e_b2f49620
PS9, Line 175: probe TABLETMODE TABLETMODE_ENABLED
Done
Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503873afb48384168dcd8a822c7246655898356e
Gerrit-Change-Number: 49469
Gerrit-PatchSet: 16
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Justin TerAvest
teravest@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 25 Jan 2021 06:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment