Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63180 )
Change subject: payloads/tianocore: Don't declare tools directory twice ......................................................................
payloads/tianocore: Don't declare tools directory twice
EDK_TOOLS_PATH is set on lines 85 and 137. Remove the instance on 85. edk2 still builds correctly.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I0c837f14693941afec194b140c93d786ea784e53 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63180 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M payloads/external/tianocore/Makefile 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile index 0908606..405af72 100644 --- a/payloads/external/tianocore/Makefile +++ b/payloads/external/tianocore/Makefile @@ -82,8 +82,6 @@
bootloader = $(word 8,$(subst /, ,$(BUILD_STR)))
-export EDK_TOOLS_PATH=$(project_dir)/BaseTools - all: clean build
$(project_dir):
-
Felix Held (Code Review)