Attention is currently required from: Tarun Tuli, Subrata Banik, Kangheui Won, Reka Norman.
Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kangheui Won, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70146
to look at the new patch set (#2).
Change subject: mb/google/brya: Don't add MPTS to both DSDT and SSDT ......................................................................
mb/google/brya: Don't add MPTS to both DSDT and SSDT
commit 52ccd293d7 started unconditionally adding MPTS to the SSDT. On variants with HAVE_WWAN_POWER_SEQUENCE selected, MPTS is already added to the DSDT via wwan_power.asl. The duplicate definition results in a kernel error: ERR kernel: [ 0.109237] ACPI BIOS Error (bug): Failure creating named object [_SB.MPTS], AE_ALREADY_EXISTS (20210730/dswload2-327) ERR kernel: [ 0.109242] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20210730/psobject-220)
Don't add MPTS to the SSDT if HAVE_WWAN_POWER_SEQUENCE is selected. There are no variants which use both, so this should only result in empty MPTS methods being removed.
BUG=b:260380268 TEST=On pujjo, the SSDT no longer contains an empty MPTS method, there's no kernel error, and the WWAN power-off sequence is met.
Change-Id: I9f411aae81ea87aa9c8fc7754c3709e398771a32 Signed-off-by: Reka Norman rekanorman@chromium.org --- M src/mainboard/google/brya/mainboard.c 1 file changed, 56 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/70146/2