Attention is currently required from: Felix Singer, Reto Buerki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80261?usp=email )
Change subject: mb/up/squared: Make mini PCIe port mode configurable ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80261/comment/f01bfc57_c8992b5a : PS2, Line 9: Add ENABLE_MSATA config knob and pad configuration to put Mini PCIe port : into mSATA mode.
Good point. […]
Hmm, I was about to suggest to disable the PCIe root port based on the Kconfig setting, would have to be in ramstage something like: ``` #include <static_devices.h> ... if (CONFIG(ENABLE_MSATA)) _dev_pcie_rp0X_ptr->enabled = 0; ``` I couldn't figure out which root port it is, though (6 are enabled but datasheet lists only 4 used?). So this might be something for another patch, iff somebody has the time and hardware to test.
I don't believe it will cause any issue to leave it enabled, btw. Because FSP should disable the root port anyway if no PCIe is connected.