Attention is currently required from: Felix Singer, Reto Buerki.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 9:
Add ENABLE_MSATA config knob and pad configuration to put Mini PCIe port
into mSATA mode.
Good point. […]
Hmm, I was about to suggest to disable the PCIe root port based on the
Kconfig setting, would have to be in ramstage something like:
```
#include <static_devices.h>
...
if (CONFIG(ENABLE_MSATA))
_dev_pcie_rp0X_ptr->enabled = 0;
```
I couldn't figure out which root port it is, though (6 are enabled but
datasheet lists only 4 used?). So this might be something for another
patch, iff somebody has the time and hardware to test.
I don't believe it will cause any issue to leave it enabled, btw.
Because FSP should disable the root port anyway if no PCIe is
connected.
To view, visit change 80261. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2da1dd4252ebb5e373bc65418e321f566d4c10f
Gerrit-Change-Number: 80261
Gerrit-PatchSet: 2
Gerrit-Owner: Reto Buerki <reet@codelabs.ch>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Reto Buerki <reet@codelabs.ch>
Gerrit-Comment-Date: Tue, 06 Feb 2024 23:19:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Comment-In-Reply-To: Reto Buerki <reet@codelabs.ch>
Gerrit-MessageType: comment