Attention is currently required from: Nick Vaccaro.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69375 )
Change subject: ec/google/chromeec: Refresh ec_commands.h ......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/ec_commands.h:
https://review.coreboot.org/c/coreboot/+/69375/comment/fab2c8e3_bb0dac7d PS4, Line 116: #define EC_LPC_CMDR_DATA BIT(0) /* Data ready for host to read */ : #define EC_LPC_CMDR_PENDING BIT(1) /* Write pending to EC */ : #define EC_LPC_CMDR_BUSY BIT(2) /* EC is busy processing a command */ : #define EC_LPC_CMDR_CMD BIT(3) /* Last host write was a command */ : #define EC_LPC_CMDR_ACPI_BRST BIT(4) /* Burst mode (not used) */ : #define EC_LPC_CMDR_SCI BIT(5) /* SCI event is pending */ : #define EC_LPC_CMDR_SMI BIT(6) /* S
Did you remove the alignment on purpose? It's harder to read without the alignment.
we run all files in the EC repo through clang format now, so that's where these formatting changes originated.