Change in coreboot[master]: mb/google/{butterfly,link,rambi,stout}: Remove unused <acpi/acpi_gnvs.h> - coreboot-gerrit

31 Jan 2021


      Attention is currently required from: Martin Roth.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50164 )
Change subject: mb/google/{butterfly,link,rambi,stout}: Remove unused <acpi/acpi_gnvs.h>
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/link/smihandler.c:
https://review.coreboot.org/c/coreboot/+/50164/comment/b2776a35_68bbd8d1 
PS1, Line 32: 0xf
Shouldn't this be `SLP_TYP_S5` ?
I'd replace "maybe wrong" `(0xf << 10)` with `(SLP_TYP_S5 << SLP_TYP_SHIFT)` or I'm wrong?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5c35f3518e2cc4d5760a64e0d38fc4843af498a
Gerrit-Change-Number: 50164
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Sun, 31 Jan 2021 06:34:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment