Attention is currently required from: Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph.
Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60991 )
Change subject: soc/intel/denverton_ns/chip.c: add soc_acpi_name function
......................................................................
Patch Set 11:
(4 comments)
Patchset:
PS9:
Looks ok. Please revert unrelated whitespace formatting changes.
Done
File src/soc/intel/denverton_ns/chip.c:
https://review.coreboot.org/c/coreboot/+/60991/comment/5e04241e_9ba7aac9
PS9, Line 186: (uint32_t)microcode_file;
unrelated whitespace change
Done
https://review.coreboot.org/c/coreboot/+/60991/comment/b2db1544_855b9e25
PS9, Line 188: (uint32_t)microcode_len;
unrelated whitespace change
Done
https://review.coreboot.org/c/coreboot/+/60991/comment/a774c339_6adbf66e
PS9, Line 197: .enable_dev = soc_enable_dev,
unrelated whitespace change
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60991
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f50733656ca7724caf8a6570bcb21f7b761c3ce
Gerrit-Change-Number: 60991
Gerrit-PatchSet: 11
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 28 Feb 2022 14:53:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-MessageType: comment