Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Xixi Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61133 )
Change subject: soc/mediatek/mt8186: Support DRAM fast calibration using blob
......................................................................
Patch Set 11:
(3 comments)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/61133/comment/9f5da0fc_39aa7ca3
PS2, Line 153: dparam->header.config |= DRAMC_CONFIG_FAST_K;
saving header in mrc_cache.
To clarify, mrc cache already contains the checksum so we don't need it in the header.
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/61133/comment/8aba1192_29b620bf
PS10, Line 146: if (!(dparam->header.config | DRAMC_CONFIG_FAST_K)) {
We should add
dparam->header.config |= DRAMC_CONFIG_FAST_K;
back, because now that the header is stored in mrc cache, it won't contain DRAMC_CONFIG_FAST_K (unless you want to set that before saving data to flash).
https://review.coreboot.org/c/coreboot/+/61133/comment/1e36e7b4_d9c29ec6
PS10, Line 149: }
Add one blank line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If25a7dd6aa6261ecff79a1b4df8b1f2e53d896dc
Gerrit-Change-Number: 61133
Gerrit-PatchSet: 11
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ron Minnich
rminnich@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Jan 2022 02:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment