Attention is currently required from: Benjamin Doron, Felix Held, Julius Werner, Lean Sheng Tan, Maximilian Brune.
Matt DeVillier has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/84796?usp=email )
Change subject: lib/fit.c: Add support for UPL style FITs
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/lib/fit.c:
https://review.coreboot.org/c/coreboot/+/84796/comment/4fe2a416_26212ca6?usp... :
PS1, Line 397: "No FDT for supporting "compat" feature!\n");
maybe reword this to more closely match the comment above?
"FDT 'compatible' property not found in config; extracting from FDT itself"
https://review.coreboot.org/c/coreboot/+/84796/comment/1096ba54_d932a45a?usp... :
PS1, Line 489: printk(BIOS_WARNING, "config %s has no FDT!\n",
curious why you downgraded this msg from ERR to WARN
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0
Gerrit-Change-Number: 84796
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 31 Oct 2024 20:13:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes