Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85709?usp=email )
Change subject: \mb/starlabs/starfighter: Put options in CFR cbtable
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/starlabs/starfighter/cfr.c:
https://review.coreboot.org/c/coreboot/+/85709/comment/b5fa5abb_b5b05a07?usp... :
PS7, Line 323: void lb_board(struct lb_header *header)
: {
: char *current = (char *)lb_new_record(header);
: struct lb_cfr *cfr_root = (struct lb_cfr *)current;
:
: cfr_write_setup_menu(cfr_root, sm_root);
: }
should be: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85709?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3e3b5448282aa81a89356f1d3145381d65e47aaa
Gerrit-Change-Number: 85709
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Sat, 11 Jan 2025 19:59:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com