Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
mb/google/hatch: set wifi sar for Akemi
Enable wifi sar feature and set wifi sar name for Akemi
BUG=b:146260789 TEST=emerge-hatch coreboot chromeos-bootimage check wifi_sar-akemi.hex in /cbfs-rw-raw/akemi
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I549e00c800985ecf8702220b276885385d928cd1 --- M src/mainboard/google/hatch/variants/akemi/variant.c 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/38937/1
diff --git a/src/mainboard/google/hatch/variants/akemi/variant.c b/src/mainboard/google/hatch/variants/akemi/variant.c index 8440b5c..e62f3a7 100644 --- a/src/mainboard/google/hatch/variants/akemi/variant.c +++ b/src/mainboard/google/hatch/variants/akemi/variant.c @@ -17,6 +17,7 @@ #include <chip.h> #include <soc/pci_devs.h> #include <ec/google/chromeec/ec.h> +#include <sar.h>
void variant_devtree_update(void) { @@ -48,3 +49,11 @@ cfg->satapwroptimize = 0; } } + +const char *get_wifi_sar_cbfs_filename(void) +{ + const char *filename = NULL; + filename = "wifi_sar-akemi.hex"; + + return filename; +}
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... PS1, Line 58: return filename; Can’t the value be returned directly without a variable?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
(1 comment)
Dear Paul, this method follow hatch/dratini. Like CL:35807. Thanks!
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... PS1, Line 58: return filename;
Can’t the value be returned directly without a variable?
Done
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... PS1, Line 58: return filename;
Done
i don't see any changes? was there another patch that was supposed to be uploaded?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... PS1, Line 58: return filename;
i don't see any changes? was there another patch that was supposed to be uploaded?
This whole function isn't necessary anyway, unless you're going to have more than one SAR file for Akemi (based on SKU).
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... PS1, Line 58: return filename;
This whole function isn't necessary anyway, unless you're going to have more than one SAR file for A […]
That's a good point.
Peichao Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
Abandoned
not need this file.
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/... PS1, Line 58: return filename;
That's a good point.
Copy that, let me delete this CL.
-
Paul Menzel (Code Review) -
Peichao Li (Code Review)
-
Shelley Chen (Code Review)
-
Tim Wawrzynczak (Code Review)