build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29189 )
Change subject: mb/google/octopus: Use a single GPIO for trackpad wake and IRQ
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/29189/3/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/29189/3/src/mainboard/google/octopus/variant...
PS3, Line 199: PAD_CFG_GPI_IRQ_WAKE(GPIO_135, NONE, DEEP, LEVEL, INVERT),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */
line over 80 characters
--
To view, visit
https://review.coreboot.org/29189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b704f1be493141629c647b79723b0025b0f7dd6
Gerrit-Change-Number: 29189
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 22 Oct 2018 02:50:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No