Change in coreboot[master]: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS - coreboot-gerrit

26 Nov 2021


      Attention is currently required from: Isaac Lee, Kane Chen, chris wang.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59558 )
Change subject: mb/google/zork/var/shuboz: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/zork/variants/shuboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59558/comment/890ce449_3f3b0e44 
PS5, Line 2: fw_config
...
Hi Kangheui, […]
So IIUC it SSFC is not set devicetree doesn't match `option AUDIO_CODEC_ALC5682 0` and emit nothing for audio? I think it should work since we treat ssfc as 0 if not set (CB:52205).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59558
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c78aa166010ffa4d0cacc8a11d418d5a6906749
Gerrit-Change-Number: 59558
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Isaac Lee isaaclee@google.com
Gerrit-Reviewer: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: chris wang Chris.Wang@amd.com
Gerrit-CC: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Randy Wang ifanw@google.com
Gerrit-Attention: Isaac Lee isaaclee@google.com
Gerrit-Attention: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Attention: chris wang Chris.Wang@amd.com
Gerrit-Comment-Date: Fri, 26 Nov 2021 00:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won khwon@chromium.org
Comment-In-Reply-To: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-MessageType: comment