Attention is currently required from: Reka Norman, Nick Vaccaro, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57697 )
Change subject: lib/Makefile.inc: Fail build if SPD file doesn't exist
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/57697/comment/5b153762_101ca6d9
PS3, Line 369: for f in $(LIB_SPD_DEPS); do \
: if [ ! -f $$f ]; then \
: echo "File not found: $$f" >&2; \
: exit 1; \
: fi; \
: for c in $$(cat $$f | grep --binary-files=text -v ^#); \
: do printf $$(printf '\%o' 0x$$c); \
nit: use moreo than 1 space for indents, e.g. 4 (or a TAB)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57697
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bdadb72e087c2ee7a88fbab2f3607bd400fa2e4
Gerrit-Change-Number: 57697
Gerrit-PatchSet: 3
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 16 Sep 2021 19:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment