Attention is currently required from: Reka Norman, Nick Vaccaro, Karthik Ramasubramanian.

Patch set 3:Code-Review +2

View Change

1 comment:

• File src/lib/Makefile.inc:

  • Patch Set #3, Line 369:

    for f in $(LIB_SPD_DEPS); do \
    	 if [ ! -f $$f ]; then \
    	  echo "File not found: $$f" >&2; \
    	  exit 1; \
    	 fi; \
    	 for c in $$(cat $$f | grep --binary-files=text -v ^#); \
    	  do printf $$(printf '\\%o' 0x$$c); \
    

    nit: use moreo than 1 space for indents, e.g. 4 (or a TAB)

To view, visit change 57697. To unsubscribe, or for help writing mail filters, visit settings.