Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal, Ivy Jian, Eric Lai, Ronak Kanabar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74161 )
Change subject: soc/intel/meteorlake: Enable VMX ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74161/comment/60efec94_603606bd PS3, Line 7: soc/intel/meteorlake: Enable VMX
Reading the diff, it’s only related to `DROP_CPU_FEATURE_PROGRAM_IN_FSP`?
today VMX enablement during MP init has done by FSP which we want to get rid starting with MTL (read the details here https://review.coreboot.org/c/coreboot/+/74167/1/src/soc/intel/meteorlake/Kc...). and would like to move it into CB (refer to cannonlakehttps://github.com/coreboot/coreboot/blob/master/src/soc/intel/cannonlake/cp...)
https://review.coreboot.org/c/coreboot/+/74161/comment/1236374f_c7195605 PS3, Line 11:
I think it was discussed in the past, that coreboot does not need to do it, but it looks like there is `ENABLE_VMX` already in Intel’s common code. I was just confused by the commit message summary/title.
i still don't understand why having Kconfig enabled is enough to ensure VMX being enabled by CB?user need to call into set_feature_ctrl_vmx_arg() or set_feature_ctrl_vmx() to program the registers https://github.com/coreboot/coreboot/blob/37ccb2ce82d1c4782356a569737dd72bf9...
-
Subrata Banik (Code Review)