Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74221 )
Change subject: soc/intel/meteorlake: Add VPU into the DMAR SATC table ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/74221/comment/802046b1_dc4faa28 PS1, Line 273: acpi_create_dmar_ds_pci
valid point.
The VPU entry should only depend on Vt-d validity along with the IPU. The updated DMAR table has the same scope with MTL BIOS/Windows. If VPU device is not enabled, no impact since the VPU kernel driver will not be loaded.
By the way, the MTL iommu kernel driver only has support for Gfx and IPU. VPU would need to be added into iommu in order to support the VPU IO virtualization. I enabled VPU, updated the iommu driver and observed the following message: pci 0000:00:0b.0: DMAR: Passthrough IOMMU for integrated Intel VPU
-
John Zhao (Code Review)