Hello Martin Roth, Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34416
to review the following change.
Change subject: nb/amd/trinity: Rename PCI ID of the IOMMU ......................................................................
nb/amd/trinity: Rename PCI ID of the IOMMU
Make the Trinity IOMMU ID naming consistent with other products.
Change-Id: Id5a03d44a2ca21061bb22f9e61b26e42d91f9d96 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/include/device/pci_ids.h M src/northbridge/amd/agesa/family15tn/iommu.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/34416/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 11cdbd0..ce08e32 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -300,7 +300,7 @@ #define PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_HT 0x15B0 #define PCI_DEVICE_ID_AMD_16H_MODEL_000F_NB_HT 0x1536 #define PCI_DEVICE_ID_AMD_16H_MODEL_303F_NB_HT 0x1566 -#define PCI_DEVICE_ID_AMD_15H_NB_IOMMU 0x1419 +#define PCI_DEVICE_ID_AMD_15H_MODEL_101F_NB_IOMMU 0x1419 #define PCI_DEVICE_ID_AMD_15H_MODEL_303F_NB_IOMMU 0x1423 #define PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU 0x1577 #define PCI_DEVICE_ID_AMD_16H_MODEL_303F_NB_IOMMU 0x1567 diff --git a/src/northbridge/amd/agesa/family15tn/iommu.c b/src/northbridge/amd/agesa/family15tn/iommu.c index d6dc7da..8bfd0b1 100644 --- a/src/northbridge/amd/agesa/family15tn/iommu.c +++ b/src/northbridge/amd/agesa/family15tn/iommu.c @@ -65,5 +65,5 @@ static const struct pci_driver iommu_driver __pci_driver = { .ops = &iommu_ops, .vendor = PCI_VENDOR_ID_AMD, - .device = PCI_DEVICE_ID_AMD_15H_NB_IOMMU, + .device = PCI_DEVICE_ID_AMD_15H_MODEL_101F_NB_IOMMU, };
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34416 )
Change subject: nb/amd/trinity: Rename PCI ID of the IOMMU ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34416 )
Change subject: nb/amd/trinity: Rename PCI ID of the IOMMU ......................................................................
Patch Set 1: Code-Review+2
Most of the time we have called it fam15tn, not trinity.
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34416 )
Change subject: nb/amd/trinity: Rename PCI ID of the IOMMU ......................................................................
nb/amd/trinity: Rename PCI ID of the IOMMU
Make the Trinity IOMMU ID naming consistent with other products.
Change-Id: Id5a03d44a2ca21061bb22f9e61b26e42d91f9d96 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34416 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/device/pci_ids.h M src/northbridge/amd/agesa/family15tn/iommu.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Martin Roth: Looks good to me, approved
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 5f2bdf0..4de75ac 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -300,7 +300,7 @@ #define PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_HT 0x15B0 #define PCI_DEVICE_ID_AMD_16H_MODEL_000F_NB_HT 0x1536 #define PCI_DEVICE_ID_AMD_16H_MODEL_303F_NB_HT 0x1566 -#define PCI_DEVICE_ID_AMD_15H_NB_IOMMU 0x1419 +#define PCI_DEVICE_ID_AMD_15H_MODEL_101F_NB_IOMMU 0x1419 #define PCI_DEVICE_ID_AMD_15H_MODEL_303F_NB_IOMMU 0x1423 #define PCI_DEVICE_ID_AMD_15H_MODEL_707F_NB_IOMMU 0x1577 #define PCI_DEVICE_ID_AMD_16H_MODEL_303F_NB_IOMMU 0x1567 diff --git a/src/northbridge/amd/agesa/family15tn/iommu.c b/src/northbridge/amd/agesa/family15tn/iommu.c index d6dc7da..8bfd0b1 100644 --- a/src/northbridge/amd/agesa/family15tn/iommu.c +++ b/src/northbridge/amd/agesa/family15tn/iommu.c @@ -65,5 +65,5 @@ static const struct pci_driver iommu_driver __pci_driver = { .ops = &iommu_ops, .vendor = PCI_VENDOR_ID_AMD, - .device = PCI_DEVICE_ID_AMD_15H_NB_IOMMU, + .device = PCI_DEVICE_ID_AMD_15H_MODEL_101F_NB_IOMMU, };
-
Kyösti Mälkki (Code Review) -
Marshall Dawson (Code Review)
-
Martin Roth (Code Review)