Attention is currently required from: Nico Huber, Maximilian Brune, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory mapped
......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68160/comment/19c41f48_c8301769
PS4, Line 91: FLASH_BIOS_BASE
If anything I would use your first suggestion. […]
Done
https://review.coreboot.org/c/coreboot/+/68160/comment/5557957b_333933fa
PS4, Line 93: $(call int-subtract, $(CONFIG_ROM_SIZE) 0x1000000))
EXT_BIOS_SIZE
Done
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/68160/comment/37cb39a1_6e2eb5ad
PS3, Line 358: optarg);
Note that this will no longer print the full argument because strtok() cuts it into pieces in-place. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38ab4c369704497f711e14ecda3ff3a8cdc0d089
Gerrit-Change-Number: 68160
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 11 Nov 2022 12:32:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment