Attention is currently required from: Nico Huber, Christian Walter, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64418 )
Change subject: security/tpm/crtm.c: Fix !CONFIG_BOOTBLOCK_IN_CBFS measuring
......................................................................
Patch Set 1:
(1 comment)
File src/security/tpm/tspi/crtm.c:
https://review.coreboot.org/c/coreboot/+/64418/comment/724471ae_9fc18523
PS1, Line 74: } /* else: TODO: Add SoC specific measurement methods. */
Well, it doesn't make sense when the loaded and the measured pieces come from […]
Yes, Arthurs patch just reveals the bug we have, agree.
What I just want to make sure here is that we have a working bootblock measurement for Apollo Lake, even if it has to be yet implemented. After a call with Arthur we have an idea how to deal with it, let's wait for that proposal.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id47ecedbc8713ebd5d9814f1c4faf43c52780447
Gerrit-Change-Number: 64418
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 17 May 2022 11:22:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment