Attention is currently required from: Tim Wawrzynczak.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49409 )
Change subject: soc/intel/tigerlake: Enable support for common IRQ block
......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS8:
JFYI, the code as-is was resulting in
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49409/comment/54e9c18f_6ff7a694
PS8, Line 252: PCH devices only
Oh yeah! Good catch 😊
JFYI, as you would probably expect, I saw some bad behavior with this patch as-is, one example being an unfielded KB interrupt spamming ec log when trying to shutdown.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49409
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb241f2b91af52a7e2d0efe997d35732882ac463
Gerrit-Change-Number: 49409
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 26 Feb 2021 02:14:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment