HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45277 )
Change subject: sb/common/acpi: convert irqlinks.asl to ASL+ Syntax ......................................................................
sb/common/acpi: convert irqlinks.asl to ASL+ Syntax
Change-Id: I92b49c56c52216906a0349e09ca3cc96bca59196 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/common/acpi/irqlinks.asl 1 file changed, 48 insertions(+), 48 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/45277/1
diff --git a/src/southbridge/intel/common/acpi/irqlinks.asl b/src/southbridge/intel/common/acpi/irqlinks.asl index 3f3386d..7d66107 100644 --- a/src/southbridge/intel/common/acpi/irqlinks.asl +++ b/src/southbridge/intel/common/acpi/irqlinks.asl @@ -8,7 +8,7 @@ // Disable method Method (_DIS, 0, Serialized) { - Store (0x80, PRTA) + PRTA = 0x80 }
// Possible Resource Settings for this Link @@ -28,10 +28,10 @@ CreateWordField(RTLA, 1, IRQ0)
// Clear the WordField - Store (Zero, IRQ0) + IRQ0 = Zero
// Set the bit from PRTA - ShiftLeft(1, And(PRTA, 0x0f), IRQ0) + IRQ0 = 1 << (PRTA & 0x0f)
Return (RTLA) } @@ -44,14 +44,14 @@ // Which bit is set? FindSetRightBit(IRQ0, Local0)
- Decrement(Local0) - Store(Local0, PRTA) + Local0-- + PRTA = Local0 }
// Status Method (_STA, 0, Serialized) { - If(And(PRTA, 0x80)) { + If (PRTA & 0x80) { Return (0x9) } Else { Return (0xb) @@ -67,7 +67,7 @@ // Disable method Method (_DIS, 0, Serialized) { - Store (0x80, PRTB) + PRTB = 0x80 }
// Possible Resource Settings for this Link @@ -87,10 +87,10 @@ CreateWordField(RTLB, 1, IRQ0)
// Clear the WordField - Store (Zero, IRQ0) + IRQ0 = Zero
// Set the bit from PRTB - ShiftLeft(1, And(PRTB, 0x0f), IRQ0) + IRQ0 = (One << (PRTB & 0x0F))
Return (RTLB) } @@ -103,14 +103,14 @@ // Which bit is set? FindSetRightBit(IRQ0, Local0)
- Decrement(Local0) - Store(Local0, PRTB) + Local0-- + PRTB = Local0, PRTB }
// Status Method (_STA, 0, Serialized) { - If(And(PRTB, 0x80)) { + If (PRTB & 0x80) { Return (0x9) } Else { Return (0xb) @@ -126,7 +126,7 @@ // Disable method Method (_DIS, 0, Serialized) { - Store (0x80, PRTC) + PRTC = 0x80 }
// Possible Resource Settings for this Link @@ -146,10 +146,10 @@ CreateWordField(RTLC, 1, IRQ0)
// Clear the WordField - Store (Zero, IRQ0) + IRQ0 = Zero
// Set the bit from PRTC - ShiftLeft(1, And(PRTC, 0x0f), IRQ0) + IRQ0 = (One << (PRTC & 0x0F))
Return (RTLC) } @@ -162,14 +162,14 @@ // Which bit is set? FindSetRightBit(IRQ0, Local0)
- Decrement(Local0) - Store(Local0, PRTC) + Local0-- + PRTC = Local0 }
// Status Method (_STA, 0, Serialized) { - If(And(PRTC, 0x80)) { + If (PRTC & 0x80) { Return (0x9) } Else { Return (0xb) @@ -185,7 +185,7 @@ // Disable method Method (_DIS, 0, Serialized) { - Store (0x80, PRTD) + PRTD = 0x80 }
// Possible Resource Settings for this Link @@ -205,10 +205,10 @@ CreateWordField(RTLD, 1, IRQ0)
// Clear the WordField - Store (Zero, IRQ0) + IRQ0 = Zero
// Set the bit from PRTD - ShiftLeft(1, And(PRTD, 0x0f), IRQ0) + IRQ0 = (One << (PRTD & 0x0F))
Return (RTLD) } @@ -221,14 +221,14 @@ // Which bit is set? FindSetRightBit(IRQ0, Local0)
- Decrement(Local0) - Store(Local0, PRTD) + Local0-- + PRTD = Local0 }
// Status Method (_STA, 0, Serialized) { - If(And(PRTD, 0x80)) { + If (PRTD & 0x80) { Return (0x9) } Else { Return (0xb) @@ -244,7 +244,7 @@ // Disable method Method (_DIS, 0, Serialized) { - Store (0x80, PRTE) + PRTE = 0x80 }
// Possible Resource Settings for this Link @@ -264,10 +264,10 @@ CreateWordField(RTLE, 1, IRQ0)
// Clear the WordField - Store (Zero, IRQ0) + IRQ0 = Zero
// Set the bit from PRTE - ShiftLeft(1, And(PRTE, 0x0f), IRQ0) + IRQ0 = (One << (PRTE & 0x0F))
Return (RTLE) } @@ -280,14 +280,14 @@ // Which bit is set? FindSetRightBit(IRQ0, Local0)
- Decrement(Local0) - Store(Local0, PRTE) + Local0-- + PRTE = Local0 }
// Status Method (_STA, 0, Serialized) { - If(And(PRTE, 0x80)) { + If (PRTE & 0x80) { Return (0x9) } Else { Return (0xb) @@ -303,7 +303,7 @@ // Disable method Method (_DIS, 0, Serialized) { - Store (0x80, PRTF) + PRTF = 0x80 }
// Possible Resource Settings for this Link @@ -323,10 +323,10 @@ CreateWordField(RTLF, 1, IRQ0)
// Clear the WordField - Store (Zero, IRQ0) + IRQ0 = Zero
// Set the bit from PRTF - ShiftLeft(1, And(PRTF, 0x0f), IRQ0) + IRQ0 = (One << (PRTF & 0x0F))
Return (RTLF) } @@ -339,14 +339,14 @@ // Which bit is set? FindSetRightBit(IRQ0, Local0)
- Decrement(Local0) - Store(Local0, PRTF) + Local0-- + PRTF = Local0 }
// Status Method (_STA, 0, Serialized) { - If(And(PRTF, 0x80)) { + If (PRTF & 0x80) { Return (0x9) } Else { Return (0xb) @@ -362,7 +362,7 @@ // Disable method Method (_DIS, 0, Serialized) { - Store (0x80, PRTG) + PRTG = 0x80 }
// Possible Resource Settings for this Link @@ -382,10 +382,10 @@ CreateWordField(RTLG, 1, IRQ0)
// Clear the WordField - Store (Zero, IRQ0) + IRQ0 = Zero
// Set the bit from PRTG - ShiftLeft(1, And(PRTG, 0x0f), IRQ0) + IRQ0 = (One << (PRTG & 0x0F))
Return (RTLG) } @@ -398,14 +398,14 @@ // Which bit is set? FindSetRightBit(IRQ0, Local0)
- Decrement(Local0) - Store(Local0, PRTG) + Local0-- + PRTG = Local0 }
// Status Method (_STA, 0, Serialized) { - If(And(PRTG, 0x80)) { + If (PRTG & 0x80) { Return (0x9) } Else { Return (0xb) @@ -421,7 +421,7 @@ // Disable method Method (_DIS, 0, Serialized) { - Store (0x80, PRTH) + PRTH = 0x80 }
// Possible Resource Settings for this Link @@ -441,10 +441,10 @@ CreateWordField(RTLH, 1, IRQ0)
// Clear the WordField - Store (Zero, IRQ0) + IRQ0 = Zero
// Set the bit from PRTH - ShiftLeft(1, And(PRTH, 0x0f), IRQ0) + IRQ0 = (One << (PRTH & 0x0F))
Return (RTLH) } @@ -457,14 +457,14 @@ // Which bit is set? FindSetRightBit(IRQ0, Local0)
- Decrement(Local0) - Store(Local0, PRTH) + Local0-- + PRTH = Local0 }
// Status Method (_STA, 0, Serialized) { - If(And(PRTH, 0x80)) { + If (PRTH & 0x80) { Return (0x9) } Else { Return (0xb)
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45277
to look at the new patch set (#2).
Change subject: sb/common/acpi: convert irqlinks.asl to ASL+ Syntax ......................................................................
sb/common/acpi: convert irqlinks.asl to ASL+ Syntax
Change-Id: I92b49c56c52216906a0349e09ca3cc96bca59196 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/common/acpi/irqlinks.asl 1 file changed, 48 insertions(+), 48 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/45277/2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45277
to look at the new patch set (#3).
Change subject: sb/common/acpi: convert irqlinks.asl to ASL 2.0 syntax ......................................................................
sb/common/acpi: convert irqlinks.asl to ASL 2.0 syntax
Change-Id: I92b49c56c52216906a0349e09ca3cc96bca59196 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/common/acpi/irqlinks.asl 1 file changed, 48 insertions(+), 48 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/45277/3
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45277
to look at the new patch set (#4).
Change subject: sb/intel/common/acpi: convert irqlinks.asl to ASL 2.0 syntax ......................................................................
sb/intel/common/acpi: convert irqlinks.asl to ASL 2.0 syntax
Change-Id: I92b49c56c52216906a0349e09ca3cc96bca59196 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/common/acpi/irqlinks.asl 1 file changed, 48 insertions(+), 48 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/45277/4
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45277 )
Change subject: sb/intel/common/acpi: convert irqlinks.asl to ASL 2.0 syntax ......................................................................
Patch Set 4:
Please feel free to delete current patch as a new one will do the "same" here CB:46760
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45277 )
Change subject: sb/intel/common/acpi: convert irqlinks.asl to ASL 2.0 syntax ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)