Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/28331 )
Change subject: mb/intel/coffeelake_rvp: Remove superfluous header file
......................................................................
Patch Set 2:
Okay, then I can move all the GPIO programming in gpio.c under
baseboard.
either that or you can link different gpio.c files for variants.
--
To view, visit
https://review.coreboot.org/28331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf3368bcf1351f0e7cd4041c3792d76362aec9e5
Gerrit-Change-Number: 28331
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Aug 2018 10:17:30 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No