Change in coreboot[master]: soc/intel/tigerlake: Add config option for S3 ACPI - coreboot-gerrit

19 Nov 2021


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59024 )
Change subject: soc/intel/tigerlake: Add config option for S3 ACPI
......................................................................
Patch Set 19:
(1 comment)
Patchset:
PS19: 
Wouldn't it make more sense to use a Kconfig option to enable/disable S0ix instead of a devicetree option, and use it here as well?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb1cc3d6a03cb452ff38ae393a993e881d9b5ff4
Gerrit-Change-Number: 59024
Gerrit-PatchSet: 19
Gerrit-Owner: Sean Rhodes admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Tim Crawford tcrawford@system76.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 14:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment