Attention is currently required from: Kevin Chiu, YH Lin, Nick Vaccaro, Shon Wang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59334 )
Change subject: mb/google/brya/var/vell: update memory settings
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
File src/mainboard/google/brya/variants/vell/memory.c:
https://review.coreboot.org/c/coreboot/+/59334/comment/cf0dd925_43c77328
PS5, Line 7: __weak
remove if you want to override
Done
https://review.coreboot.org/c/coreboot/+/59334/comment/424c24e8_986c7548
PS5, Line 26: __weak
remove if you want to override
Done
File src/mainboard/google/brya/variants/vell/memory.c:
https://review.coreboot.org/c/coreboot/+/59334/comment/0afb550a_087ced9c
PS6, Line 16: 40, 30, 30, 30, 30
I believe Intel's recommended values for LP5 are
`40, 36, 35, 35, 35`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59334
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0bbac5eaebc77639be6c1bc399658ac90e72fbb
Gerrit-Change-Number: 59334
Gerrit-PatchSet: 6
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 24 Nov 2021 17:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-MessageType: comment