Attention is currently required from: shkim, Henry Sun, SH Kim, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 )
Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
......................................................................
Patch Set 8:
(5 comments)
File src/mainboard/google/dedede/variants/bugzzy/ramstage.c:
https://review.coreboot.org/c/coreboot/+/60190/comment/732fb3fe_eb76d2f6
PS8, Line 7: #include <drivers/intel/gma/i915_reg.h>
#include <soc/pci_devs.h>
https://review.coreboot.org/c/coreboot/+/60190/comment/0a3a3214_2519b2d6
PS8, Line 9: #define IGD_MMIO_BASE 0xc0010000
#define IGD_MMIO_BASE(Bus, Dev, Func) (CONFIG_MMCONF_BASE_ADDRESS + (Bus << 20) + (Dev << 15) + (Func << 12))
https://review.coreboot.org/c/coreboot/+/60190/comment/0a248284_5744042f
PS8, Line 27: addr32 = IGD_MMIO_BASE;
addr32 = IGD_MMIO_BASE(0, SA_DEV_SLOT_IGD, 0);
https://review.coreboot.org/c/coreboot/+/60190/comment/b3d6a124_2c4b1530
PS8, Line 29: addr32 = IGD_MMIO_BASE + 0x10;
addr32 = IGD_MMIO_BASE(0, 2, 0) + PCI_BASE_ADDRESS_0;
https://review.coreboot.org/c/coreboot/+/60190/comment/664f1b7c_909c702e
PS8, Line 36: 0xc7204
PCH_PP_CONTROL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db
Gerrit-Change-Number: 60190
Gerrit-PatchSet: 8
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Edward Doan
edoan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: shkim
sh_.kim@samsung.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Attention: Edward Doan
edoan@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 20 Dec 2021 08:49:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment