Change in coreboot[master]: util/release/genrelnotes: Emit more markdown-ish output

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Georgi (Code Review)

23 Jul 2019 23 Jul '19

2:38 a.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34504 )

Change subject: util/release/genrelnotes: Emit more markdown-ish output ......................................................................

util/release/genrelnotes: Emit more markdown-ish output

It's better to format lists with bullet points.

Change-Id: I503ef2dea9146d67c220236b8a5b64c2ba2d794f Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/release/genrelnotes 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/34504/1

diff --git a/util/release/genrelnotes b/util/release/genrelnotes index e4f304b..c9ca549 100755 --- a/util/release/genrelnotes +++ b/util/release/genrelnotes @@ -202,12 +202,12 @@ local new local old

- new="$(comm -13 <(echo "$2") <(echo "$3"))" + new="$(comm -13 <(echo "$2") <(echo "$3") | sed 's/^/* /')" if [ -n "$new" ]; then printf "Added %s $1:\n-------------------\n%s\n\n" \ "$(echo "$new" | wc -l)" "$new" >> "$LOGFILE" fi - old="$(comm -23 <(echo "$2") <(echo "$3"))" + new="$(comm -23 <(echo "$2") <(echo "$3") | sed 's/^/* /')" if [ -n "$old" ]; then printf "Removed %s $1:\n-------------------\n%s\n\n" \ "$(echo "$old" | wc -l)" "$old" >> "$LOGFILE"

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

HAOUAS Elyes (Code Review)

23 Jul 23 Jul

7:40 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34504 )

Change subject: util/release/genrelnotes: Emit more markdown-ish output ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34504/1/util/release/genrelnotes File util/release/genrelnotes:

https://review.coreboot.org/c/coreboot/+/34504/1/util/release/genrelnotes@21... PS1, Line 210: new was "old", is it intentional ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I503ef2dea9146d67c220236b8a5b64c2ba2d794f Gerrit-Change-Number: 34504 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Tue, 23 Jul 2019 05:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9:45 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34504

to look at the new patch set (#2).

Change subject: util/release/genrelnotes: Emit more markdown-ish output ......................................................................

util/release/genrelnotes: Emit more markdown-ish output

It's better to format lists with bullet points.

Change-Id: I503ef2dea9146d67c220236b8a5b64c2ba2d794f Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/release/genrelnotes 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/34504/2

Patrick Georgi (Code Review)

9:46 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34504 )

Change subject: util/release/genrelnotes: Emit more markdown-ish output ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34504/1/util/release/genrelnotes File util/release/genrelnotes:

https://review.coreboot.org/c/coreboot/+/34504/1/util/release/genrelnotes@21... PS1, Line 210: new

...

was "old", is it intentional ?

Good catch, fixed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I503ef2dea9146d67c220236b8a5b64c2ba2d794f Gerrit-Change-Number: 34504 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Tue, 23 Jul 2019 07:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:08 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34504 )

Change subject: util/release/genrelnotes: Emit more markdown-ish output ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I503ef2dea9146d67c220236b8a5b64c2ba2d794f Gerrit-Change-Number: 34504 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Tue, 23 Jul 2019 09:08:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

31 Jul 31 Jul

4:14 a.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34504 )

Change subject: util/release/genrelnotes: Emit more markdown-ish output ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I503ef2dea9146d67c220236b8a5b64c2ba2d794f Gerrit-Change-Number: 34504 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Wed, 31 Jul 2019 02:14:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10:47 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34504 )

Change subject: util/release/genrelnotes: Emit more markdown-ish output ......................................................................

util/release/genrelnotes: Emit more markdown-ish output

It's better to format lists with bullet points.

Change-Id: I503ef2dea9146d67c220236b8a5b64c2ba2d794f Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34504 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/release/genrelnotes 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve

diff --git a/util/release/genrelnotes b/util/release/genrelnotes index e4f304b..2867cbf 100755 --- a/util/release/genrelnotes +++ b/util/release/genrelnotes @@ -202,12 +202,12 @@ local new local old

- new="$(comm -13 <(echo "$2") <(echo "$3"))" + new="$(comm -13 <(echo "$2") <(echo "$3") | sed 's/^/* /')" if [ -n "$new" ]; then printf "Added %s $1:\n-------------------\n%s\n\n" \ "$(echo "$new" | wc -l)" "$new" >> "$LOGFILE" fi - old="$(comm -23 <(echo "$2") <(echo "$3"))" + old="$(comm -23 <(echo "$2") <(echo "$3") | sed 's/^/* /')" if [ -n "$old" ]; then printf "Removed %s $1:\n-------------------\n%s\n\n" \ "$(echo "$old" | wc -l)" "$old" >> "$LOGFILE"

-- To view, visit https://review.coreboot.org/c/coreboot/+/34504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I503ef2dea9146d67c220236b8a5b64c2ba2d794f Gerrit-Change-Number: 34504 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: merged

1933

days inactive

1941

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)