Change in ...coreboot[master]: src/arch/arm64: Remove variable set but not used

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32888

Change subject: src/arch/arm64: Remove variable set but not used
......................................................................

src/arch/arm64: Remove variable set but not used

Change-Id: I4fe5771dd1ebf3d2a981dab08e98f1c018d14133
Signed-off-by: Elyes HAOUAS 
---
M src/arch/arm64/boot.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/32888/1

diff --git a/src/arch/arm64/boot.c b/src/arch/arm64/boot.c
index d17a20d..dc53b6d 100644
--- a/src/arch/arm64/boot.c
+++ b/src/arch/arm64/boot.c
@@ -38,7 +38,6 @@
 void arch_prog_run(struct prog *prog)
 {
    void (*doit)(void *);
-	void *arg;

if (ENV_RAMSTAGE && prog_type(prog) == PROG_PAYLOAD) {
    	run_payload(prog);
@@ -46,7 +45,7 @@
    }

doit = prog_entry(prog);
-	arg = prog_entry_arg(prog);
+	prog_entry_arg(prog);

doit(prog_entry_arg(prog));
 }

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32888 )

Change subject: src/arch/arm64: Remove variable set but not used
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32888/2/src/arch/arm64/boot.c 
File src/arch/arm64/boot.c:

https://review.coreboot.org/#/c/32888/2/src/arch/arm64/boot.c@48 
PS2, Line 48: 	prog_entry_arg(prog);
This function has no effect other than returning the argument, so just remove the line entirely (it's called again below).

[HAOUAS Elyes (Code Review)]

Hello Julius Werner, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32888

to look at the new patch set (#3).

Change subject: src/arch/arm64: Remove variable set but not used
......................................................................

src/arch/arm64: Remove variable set but not used

Change-Id: I4fe5771dd1ebf3d2a981dab08e98f1c018d14133
Signed-off-by: Elyes HAOUAS 
---
M src/arch/arm64/boot.c
1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/32888/3

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32888 )

Change subject: src/arch/arm64: Remove variable set but not used
......................................................................

Patch Set 3: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32888 )

Change subject: src/arch/arm64: Remove variable set but not used
......................................................................

src/arch/arm64: Remove variable set but not used

Change-Id: I4fe5771dd1ebf3d2a981dab08e98f1c018d14133
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32888
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
---
M src/arch/arm64/boot.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/arch/arm64/boot.c b/src/arch/arm64/boot.c
index d17a20d..7fbc525 100644
--- a/src/arch/arm64/boot.c
+++ b/src/arch/arm64/boot.c
@@ -38,7 +38,6 @@
 void arch_prog_run(struct prog *prog)
 {
    void (*doit)(void *);
-	void *arg;

if (ENV_RAMSTAGE && prog_type(prog) == PROG_PAYLOAD) {
    	run_payload(prog);
@@ -46,7 +45,6 @@
    }

doit = prog_entry(prog);
-	arg = prog_entry_arg(prog);

doit(prog_entry_arg(prog));
 }