[S] Change in coreboot[main]: soc/intel/pantherlake: Display Sign-of-Life during memory training

[Jérémy Compostella (Code Review)]

Attention is currently required from: Alok Agarwal, Anil Kumar K, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik, Vikrant L Jadeja.

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85454?usp=email )

Change subject: soc/intel/pantherlake: Display Sign-of-Life during memory training
......................................................................

Patch Set 17:

(4 comments)

Patchset:

PS11:
> The UPD are being used a bit differently, especially at the moment. […]

Done

Commit Message:

https://review.coreboot.org/c/coreboot/+/85454/comment/00fe6c0b_cee68512?usp... :
PS11, Line 47: The SOC_INTEL_PANTHERLAKE_SIGN_OF_LIFE flag also selects the LZ4
             : compression algorithm for the Video BIOS Tables (VBT), as LZMA
             : decompression is not available by default during the romstage
             : phase. Integrating LZMA support would increase the romstage binary
             : size by an amount greater than the reduction achieved by compressing
             : the VBT binary using LZMA.
> Why 72-character ? According to https://doc.coreboot.org/contributing/gerrit_guidelines. […]

Done

File src/soc/intel/pantherlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/85454/comment/7456f5e9_8e3aa45a?usp... :
PS16, Line 366: 
              : #define UX_MEMORY_TRAINING_DESC	"memory_training_desc"
> not needed

Done

https://review.coreboot.org/c/coreboot/+/85454/comment/4837cf0e_bb7a08fd?usp... :
PS16, Line 384: 	const char *text = ux_locales_get_text(UX_MEMORY_TRAINING_DESC);
              : 	/* No localized text found; fallback to built-in English. */
              : 	if (!text)
              : 		text = "Your device is finishing an update. "
              : 		       "This may take 1-2 minutes.\n"
              : 		       "Please do not turn off your device.";
> just use […]

Done