build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: src/mainboard/supermicro/x11-lga1151v2-series: Add Support for X11SCH-F ......................................................................
Patch Set 48:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... PS48, Line 18: const struct pad_config * early_gpio_table = get_early_gpio_table(&num); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/memory.c:
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... PS48, Line 44: const struct cnl_mb_cfg * variant_memcfg_config(void) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... PS48, Line 10: size_t num = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... PS48, Line 11: const struct pad_config * gpio_table = get_gpio_table(&num); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... PS48, Line 11: const struct pad_config * gpio_table = get_gpio_table(&num); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/variants/x11sch-f/include/variant/variants.h:
https://review.coreboot.org/c/coreboot/+/37441/48/src/mainboard/supermicro/x... PS48, Line 6: const struct cnl_mb_cfg *variant_memcfg_config(void); adding a line without newline at end of file