Change in coreboot[master]: soc/amd/cezanne/early_fch: move mb_set_up_early_espi into if block - coreboot-gerrit

24 Sep 2021


      Attention is currently required from: Raul Rangel, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57781 )
Change subject: soc/amd/cezanne/early_fch: move mb_set_up_early_espi into if block
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/amd/cezanne/early_fch.c:
https://review.coreboot.org/c/coreboot/+/57781/comment/5af594d6_82fd113f 
PS1, Line 39: mb_set_up_early_espi
...
Not sure we want to do this: https://source.chromium. […]
I don't think it should matter. This function only gets if we're not using psp_verstage.  If psp_verstage is run, espi gets set up there.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8ad724a2a79c1995fbe9d97f11a0f69eed9435c
Gerrit-Change-Number: 57781
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 24 Sep 2021 15:18:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Gerrit-MessageType: comment