Attention is currently required from: Shaunak Saha, Furquan Shaikh, Martin Roth, Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51649 )
Change subject: soc/intel/tgl,mb/google/volteer: Add API for Type-C aux bias pads
......................................................................
Patch Set 22:
(3 comments)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/51649/comment/16533a28_7b66e34a
PS22, Line 325: cpu_pid
Isn't this the same as cpu_portid above?
haha oh yeah 😊
https://review.coreboot.org/c/coreboot/+/51649/comment/9cc91249_3e7db066
PS22, Line 331: tcss_configure_aux_bias_pads
Now that this function is implemented in the common tcss driver, should it be called from `tcss_conf […]
Sure, then `tcss_configure` has to take the parameters too, b/c the field exists in the SoC `chip.h` and common code can't include that file.
https://review.coreboot.org/c/coreboot/+/51649/comment/2f5b0c7b_47c0acad
PS22, Line 333: MAX_TYPE_C_PORTS
Not for this change, but I think we should change this to a Kconfig. […]
Do you know something I don't? 😜
I don't know if a Kconfig makes sense, it's not something that the user can change (it's a property of the SoC itself)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70e36a41e760f4a435511c147cc5744a77dbccc0
Gerrit-Change-Number: 51649
Gerrit-PatchSet: 22
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 04 May 2021 17:27:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment