Attention is currently required from: Shaunak Saha, Furquan Shaikh, Martin Roth, Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph.
3 comments:
File src/soc/intel/common/block/tcss/tcss.c:
Patch Set #22, Line 325: cpu_pid
Isn't this the same as cpu_portid above?
haha oh yeah 😊
Patch Set #22, Line 331: tcss_configure_aux_bias_pads
Now that this function is implemented in the common tcss driver, should it be called from `tcss_conf […]
Sure, then `tcss_configure` has to take the parameters too, b/c the field exists in the SoC `chip.h` and common code can't include that file.
Patch Set #22, Line 333: MAX_TYPE_C_PORTS
Not for this change, but I think we should change this to a Kconfig. […]
Do you know something I don't? 😜
I don't know if a Kconfig makes sense, it's not something that the user can change (it's a property of the SoC itself)?
To view, visit change 51649. To unsubscribe, or for help writing mail filters, visit settings.